Improve poll dialogs TalkBack accessibility by andremion · Pull Request #6466 · GetStream/stream-chat-android

andremion · 2026-05-22T12:20:47Z

AND-1180

Goal

The poll-results bottom sheet, the per-option votes screen, the comments dialog, and the more-options dialog were hard to navigate with TalkBack: the screen title wasn't announced on open, sub-section labels weren't navigable as headings, vote/comment rows produced one focus per child element (avatar, name, date), and the radio/checkbox in the more-options dialog was unlabeled. This PR fixes all of that so each row is a single focus with a meaningful announcement, and dialog titles identify their screen.

Implementation

PollDialogHeader (shared by all four poll dialogs): title Text carries heading() semantics, and the header sends a programmatic view.announceForAccessibility(title) on first composition. ModalBottomSheet swallows the standard paneTitle window-state-changed event, so programmatic announce is the reliable workaround.
PollVoteItem (shared by results + per-option votes screens): the row merges its descendants so each vote announces as one focus (avatar + name + date).
PollViewResultDialog: option header (Option N) + summary row (option text + winner badge + vote count) wrapped in a merged Column with heading() — one focus per option summary, navigable via TalkBack's heading shortcut. Question section also merged with heading().
PollOptionVotesDialog: the trophy-and-vote-count header row above the votes list is merged.
PollAnswers: each comment card merges the answer text with the user/timestamp row into one focus; the "Update Your Comment" button stays as its own separate focus.
PollMoreOptionsDialog: applies the same pattern as the just-merged inline poll (PollMessageContent, Improve poll vote row TalkBack accessibility #6461): each option row is toggleable with Role.RadioButton (single-vote polls) or Role.Checkbox (multi-vote), the RadioCheck is hidden from accessibility since the toggleable row already conveys state, the vote count gets a plural contentDescription, and the LinearProgressIndicator is removed from the semantics tree (the row already carries the count). Question section also merged with heading().

No visible UI changes; layout, colours, and behaviour are unchanged.

Testing

Enable TalkBack.
Long-press a poll message and open View Results:
- Sheet open should announce the screen title ("Poll Results").
- Swiping right should focus the back button, then the question section (one focus, announced as a heading), then each option summary ("Option 1, A, 3 votes" / "Option 1, A, Winner badge, 3 votes"), then each vote row as one focus, then the "Show all" button (when present), then the total votes count.
- TalkBack's heading-navigation shortcut should jump between the question and each option.
From the results screen, tap Show all on an option:
- The per-option votes screen should announce its title (the option text).
- The top header row should announce "Winner badge, 3 votes" as one focus (when the option is the winner).
- Each vote announces as a single merged focus.
Open View Comments on a poll with answers:
- Title should be announced as "Poll Comments".
- Each comment card should announce as one focus (comment text, user, timestamp). The "Update Your Comment" button (on the current user's own answer) is a separate focus.
Open a poll with more options than the inline preview shows, tap Show all options:
- Title should be announced.
- Each option row should announce as one focus, including option text, vote count and toggle state ("not checked / checked, RadioButton" or "Checkbox"); double-tap toggles the vote.
- The question section should announce as one focus and act as a heading.

Summary by CodeRabbit

Improvements
- Enhanced accessibility support across poll components with improved screen reader compatibility.
- Added semantic structure for better navigation and content description of poll titles and options.
- Improved vote interaction feedback with clearer accessibility descriptions for vote counts.

andremion · 2026-05-22T12:20:54Z

@CodeRabbit review

github-actions · 2026-05-22T12:21:00Z

PR checklist ✅

All required conditions are satisfied:

Title length is OK (or ignored by label).
At least one pr: label exists.
Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

coderabbitai · 2026-05-22T12:21:00Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-05-22T12:23:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c83f6a45-1f66-4585-af86-3cae5af6a903

📥 Commits

Reviewing files that changed from the base of the PR and between 0b68a9e and c4ec0e5.

📒 Files selected for processing (6)

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollAnswers.kt
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollDialogHeader.kt
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollMoreOptionsDialog.kt
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollOptionVotesDialog.kt
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollViewResultDialog.kt
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollVoteItem.kt

Walkthrough

This PR improves accessibility across six poll UI components in Stream Chat Android Compose by adding semantics imports, marking dialog titles as headings with announcements, grouping content with merged-descendants semantics, and enhancing vote interaction with dynamic toggle roles and pluralized semantic descriptions for screen readers.

Changes

Poll Accessibility Enhancements

Layer / File(s)	Summary
Semantics imports and foundation `stream-chat-android-compose/.../poll/PollAnswers.kt`, `PollDialogHeader.kt`, `PollMoreOptionsDialog.kt`, `PollOptionVotesDialog.kt`, `PollViewResultDialog.kt`, `PollVoteItem.kt`	Adds Compose `semantics` imports and utility imports (`LaunchedEffect`, `LocalView`, `toggleable`, `applyIf`) needed for accessibility updates across all poll UI files.
Dialog headers and title semantics `stream-chat-android-compose/.../poll/PollDialogHeader.kt`, `PollMoreOptionsDialog.kt`, `PollViewResultDialog.kt`	Dialog titles are marked as semantic headings; `PollDialogHeader` announces title changes via accessibility API for TalkBack readers.
Content grouping with merged semantics `stream-chat-android-compose/.../poll/PollAnswers.kt`, `PollVoteItem.kt`, `PollViewResultDialog.kt`, `PollOptionVotesDialog.kt`	Answer items, vote items, result items, and winner rows are wrapped in containers with `mergeDescendants = true` to group related content as single accessibility units.
Vote interaction and semantic descriptions `stream-chat-android-compose/.../poll/PollMoreOptionsDialog.kt`	Vote options gain dynamic `toggleRole` (radio or checkbox based on `maxVotesAllowed`), vote handlers gated by poll state, pluralized vote-count descriptions exposed via `contentDescription`, and progress indicators explicitly cleared of semantics.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

GetStream/stream-chat-android#6461: Related poll vote accessibility improvements including toggleRole/toggleable semantics and vote-count semantic descriptions.

Suggested reviewers

gpunto

Poem

🐰 Polls now speak clear for those who listen,
Headings marked and votes glow 'round,
Merged semantics make the tree shimmer bright,
Radio buttons and checkboxes know their role,
Accessibility hops forward, bound!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: TalkBack accessibility improvements across poll dialogs, which is the primary focus of all modifications in the changeset.
Description check	✅ Passed	The description includes Goal, Implementation with technical details, and comprehensive Testing instructions. However, it lacks UI Changes screenshots/videos section and Contributor/Reviewer Checklists from the template.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/compose-poll-results-sheet-a11y

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-22T12:25:31Z

SDK Size Comparison 📏

SDK	Before	After	Status
stream-chat-android-client	5.83 MB	5.83 MB	🟢
stream-chat-android-ui-components	11.04 MB	11.04 MB	🟢
stream-chat-android-compose	12.46 MB	12.46 MB	🟢

gpunto

Looks good!

After extracting PollOptionVotingRow, PollOptionItem became a pass-through that forwards twelve parameters with no transformation. Inline the call site to use PollOptionVotingRow directly and drop the wrapper along with its LongParameterList suppression.

sonarqubecloud · 2026-05-27T15:22:16Z

Quality Gate failed

Failed conditions
76.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

When the emoji picker `ModalBottomSheet` opened from the "+" in the reactions bar, TalkBack focused the drag handle and announced "Collapsed, drag handle, actions available, swipe up or swipe down". Screen-reader users had no signal that the emoji picker had appeared and the drag handle drowned out the actual content. `ModalBottomSheet` swallows the standard `paneTitle` window-state event (verified in #6466 / `PollDialogHeader`), so announce the title programmatically via `view.announceForAccessibility` in a `LaunchedEffect`. TalkBack now reads "Emoji picker" on sheet open. Hide the drag handle from the accessibility tree via `Modifier.semantics { hideFromAccessibility() }`. The handle stays visually present and remains draggable for sighted users; TalkBack focus skips it and lands on the first emoji in the picker grid instead. One new string (`stream_compose_emoji_picker_title`) translated across the 7 supported locales. No public API changes.

stream-public-bot · 2026-06-05T08:59:40Z

🚀 Available in v7.3.0

andremion added 3 commits May 22, 2026 11:35

Improve poll results TalkBack accessibility

8f2db60

Improve poll answers and more-options dialog TalkBack accessibility

2a73eb4

Improve poll option votes dialog TalkBack accessibility

c4ec0e5

andremion requested a review from a team as a code owner May 22, 2026 12:20

andremion added the pr:improvement Improvement label May 22, 2026

Extract shared poll option voting row

afecec4

andremion enabled auto-merge (squash) May 22, 2026 13:08

gpunto approved these changes May 27, 2026

View reviewed changes

Comment thread ...src/main/java/io/getstream/chat/android/compose/ui/components/messages/PollMessageContent.kt Outdated

andremion added 2 commits May 27, 2026 14:02

Merge branch 'develop' into fix/compose-poll-results-sheet-a11y

8bbb6aa

gpunto approved these changes May 27, 2026

View reviewed changes

andremion added 3 commits May 27, 2026 14:36

Merge branch 'develop' into fix/compose-poll-results-sheet-a11y

87b45bf

Merge branch 'develop' into fix/compose-poll-results-sheet-a11y

89e0e34

Merge branch 'develop' into fix/compose-poll-results-sheet-a11y

8b9aa11

andremion disabled auto-merge May 27, 2026 14:16

Merge branch 'develop' into fix/compose-poll-results-sheet-a11y

93b3300

andremion merged commit bcc03be into develop May 28, 2026
18 of 21 checks passed

andremion deleted the fix/compose-poll-results-sheet-a11y branch May 28, 2026 10:03

andremion mentioned this pull request Jun 2, 2026

Improve message actions menu TalkBack accessibility #6484

Draft

stream-public-bot added the released Included in a release label Jun 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve poll dialogs TalkBack accessibility#6466

Improve poll dialogs TalkBack accessibility#6466
andremion merged 10 commits into
developfrom
fix/compose-poll-results-sheet-a11y

andremion commented May 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

andremion commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 22, 2026

Uh oh!

coderabbitai Bot commented May 22, 2026

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented May 22, 2026 •

edited

Loading

Uh oh!

gpunto left a comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 27, 2026

Uh oh!

Uh oh!

stream-public-bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

andremion commented May 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Implementation

Testing

Summary by CodeRabbit

Uh oh!

andremion commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist ✅

Uh oh!

coderabbitai Bot commented May 22, 2026

Uh oh!

coderabbitai Bot commented May 22, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size Comparison 📏

Uh oh!

gpunto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 27, 2026

Quality Gate failed

Uh oh!

Uh oh!

stream-public-bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andremion commented May 22, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading